Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.6 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

024

POST /api/auth/reset-password-with-code accepts weak passwords — no complexity validation

major

auth

backend

security

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 POST /api/auth/reset-password-with-code accepts weak passwords — no complexity validation

Severity: major Domain: auth Labels: backend, security, bug

Description

POST /api/auth/reset-password-with-code has no passwordResetValidation middleware (authRoutes.ts line ~54-57). The controller only validates that email, code, and password fields are present, and that the code is 6 digits.

Passwords like '123456', 'aaaaaa', or 'password' are accepted.

By contrast, the legacy POST /api/auth/reset-password (token-based) is wired with passwordResetValidation which enforces /^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)/ — at least one uppercase, one lowercase, one digit.

Current Behavior

POST /api/auth/reset-password-with-code with { email, code: "123456", password: "aaaaaa" } → 200, password reset to weak value.

Expected Behavior

Apply passwordResetValidation (or equivalent inline validation) to reset-password-with-code as well.

Affected Files

backend/src/routes/authRoutes.ts — line ~54-57, add passwordResetValidation middleware
backend/src/shared/middleware/authValidation.ts — passwordResetValidation definition

References

Doc vs Code Audit Report — Finding M6

1.6 KiB Raw Blame History