Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

2.1 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

018

Trezor Safekeeping has zero frontend implementation — all backend endpoints unreachable from UI

critical

trezor

frontend

missing-feature

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 Trezor Safekeeping has zero frontend implementation — all backend endpoints unreachable from UI

Severity: critical Domain: trezor Labels: frontend, missing-feature

Description

A comprehensive search of all .ts and .tsx files in frontend/src/ finds zero calls to any Trezor backend endpoint. There is no:

Trezor registration page
xpub input UI
Trezor Connect SDK import
Admin Trezor signing panel
Any action calling /api/trezor/*

The only Trezor reference in the entire frontend is a brand logo in wallet-icons.ts.

The documented 12-step challenge-sign-submit flow exists entirely in the backend but has no frontend surface at any step.

Additionally, confirmReleaseTx and confirmRefundTx in frontend/src/actions/payment.ts post { txHash, ...extra } with no trezor object (message + signature). With TREZOR_SAFEKEEPING_REQUIRED=true, every admin release/refund from the UI will be rejected by the backend's assertTrezorSignatureForOperation guard.

Current Behavior

No UI exists for Trezor registration
Admin release/refund with TREZOR_SAFEKEEPING_REQUIRED=true always fails (missing signature payload)
All Trezor API endpoints are only testable via curl/Postman

Expected Behavior

A complete frontend implementation covering:

Trezor registration page (xpub input, challenge-sign-submit flow)
Operation signing UI for admin release/refund (call POST /api/trezor/operation-message, prompt sign, attach trezor object to confirm body)

Affected Files

frontend/src/actions/payment.ts — confirmReleaseTx, confirmRefundTx missing trezor field
Missing: Trezor registration page component
Missing: Admin Trezor signing integration in dispute/payment admin panels

References

Doc vs Code Audit Report — Findings C31, C32

2.1 KiB Raw Blame History