dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
issue: 121
|
|
title: "Frontend: transferFunds and createPayment POST to the same endpoint"
|
|
severity: low
|
|
domain: Payment
|
|
labels: [bug, frontend]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend: transferFunds and createPayment POST to the same endpoint
|
|
|
|
**Severity:** low
|
|
**Domain:** Payment
|
|
**Labels:** bug, frontend
|
|
|
|
## Description
|
|
|
|
`src/actions/payment.ts:186` — `transferFunds` and `createPayment` both POST to the same backend endpoint. It is unclear whether this is intentional (payload-shape disambiguation on the backend) or an error where `transferFunds` should use a dedicated route.
|
|
|
|
## Options
|
|
|
|
1. Give `transferFunds` a dedicated backend route + frontend endpoint constant.
|
|
2. Keep shared endpoint but document the backend disambiguation contract.
|
|
3. Merge the two functions if they are truly the same operation.
|
|
|
|
## Recommendation
|
|
|
|
Confirm backend routing intent; if distinct operations, introduce a dedicated endpoint.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/src/actions/payment.ts:186`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-14
|