Files

Siavash Sameni 7a616744f4 docs: complete code-reality alignment for remaining docs + reconcile issue set

Remaining docs updated to match code (the docs that the first pass had not covered):
- Flows: Chat, Referral, Rating, Registration, Google OAuth, Negotiation, Payout,
  Trezor Safekeeping — corrected endpoints, socket events, status enums, auth gaps
- API Reference: User API, Trezor API — admin route prefix/verb/status corrections,
  added undocumented endpoints (ton-proof challenge, profile email verify,
  GET /trezor/account, POST /trezor/verify-operation)
- Data Models: Chat, Notification, Payment, PointTransaction, User — corrected
  enums (PaymentProvider, escrowState, PointTransaction.type, User.status),
  90-day notification TTL, soft-delete semantics, wallet fields

Trezor "zero frontend" finding (audit C31/C32) corrected as STALE:
- Verified current code HAS a full frontend Trezor implementation (admin/trezor
  page, TrezorSettingsView, trezorConnector via @trezor/connect-web,
  TrezorSignDialog, actions/trezor.ts building the {message,signature} object)
- Fixed Trezor Safekeeping Flow doc (removed false "no frontend" warnings)
- Reclassified ISSUE-012 as invalid/superseded with explanation

Issue set reconciled to a single canonical numbering (ISSUE-001..054):
- Adopted the comprehensive 51-issue set (long-slug, fully indexed)
- Removed 35 superseded short-slug duplicates from the first pass
- Removed a duplicate ISSUE-046 file
- Added 3 issues the 51-set lacked: ISSUE-052 (completed-not-counted-in-stats),
  ISSUE-053 (axios 401-only interceptor), ISSUE-054 (rate limiter counts all attempts)
- Regenerated Issues Index: 53 open (14 critical, 39 major) + 1 invalid

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-05-29 15:15:02 +04:00

1.4 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

052

'completed' payment status not counted in successfulPayments stats — admin dashboard undercounts

major

Payment

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 'completed' payment status not counted in successfulPayments stats — admin dashboard undercounts

Severity: major Domain: Payment Labels: backend, bug

Description

paymentService.getPaymentStats() aggregate counts only 'confirmed' as successfulPayments. 'completed' is excluded. Most SHKeeper/DePay payments follow the terminal path pending → processing → completed, so the bulk of successful payments are invisible in the success count.

Current Behavior

Admin dashboard successfulPayments count excludes all 'completed' payments. For a platform where SHKeeper is the primary provider, this count reads close to zero even after many successful payments.

Expected Behavior

successfulPayments should count both 'confirmed' and 'completed' (the terminal success states), or the stat should be clearly documented as confirmed-only.

Affected Files

backend/src/services/payment/paymentService.ts — getPaymentStats() aggregate pipeline

References

Doc vs Code Audit Report — Finding M36

1.4 KiB Raw Blame History