dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.4 KiB
1.4 KiB
issue, title, severity, domain, status, resolved, fix, labels, status, created, source
| issue | title | severity | domain | status | resolved | fix | labels | status | created | source | ||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 026 | GET /notifications/:id only returns user's most-recent notification — all others return 404 erroneously | major | Notification | resolved | 2026-05-29 | Fixed getNotificationById in notificationController.ts to use Notification.findOne({ _id: id, userId }) instead of fetching page 1 of user notifications. |
|
open | 2026-05-29 | Doc vs Code Audit 2026-05-29 |
🟠 GET /notifications/:id only returns user's most-recent notification — all others return 404 erroneously
Severity: major Domain: Notification Labels: bug, backend, major, broken-feature
Description
The backend getNotificationById controller calls getUserNotifications(userId, 1, 1) — fetching page 1 with limit 1 — then does an in-memory _id string match. Any notification that is not the single most-recent record for that user always returns 404, regardless of ownership.
Current Behavior
GET /notifications/:id returns 404 for all notifications except the user's most recently created one.
Expected Behavior
getNotificationById should perform a direct MongoDB query by _id and userId: Notification.findOne({_id, userId}).
Affected Files
backend/src/controllers/notificationController.ts