dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.1 KiB
1.1 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | ||
|---|---|---|---|---|---|---|---|---|---|
| 130 | Scanner: Config.GetChain/GetToken/GetRPC O(N) linear scans — pre-index at load time | low | Scanner |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Scanner: Config.GetChain/GetToken/GetRPC O(N) linear scans — pre-index at load time
Severity: low Domain: Scanner Labels: performance, scanner
Description
scanner/config.go:199 implements GetChain, GetToken, and GetRPC as linear scans over slices on every call. While chain count is small, these are called in hot paths (per-intent lookups). Pre-building maps at config load would eliminate all repeated scans.
Options
- Build maps (by chainId, token key) once at config load.
- Leave as-is given small chain count.
- Cache results per request.
Recommendation
Build lookup maps at config load; trivial change but slightly alters config initialization.
Affected Files
scanner/config.go:199
References
- Full Codebase Audit 2026-05-30 — DEC-69