dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.4 KiB
Markdown
39 lines
1.4 KiB
Markdown
---
|
|
issue: 099
|
|
title: "Backend: on-demand RN reconciliation in getPaymentById can race — double-processing risk"
|
|
severity: medium
|
|
domain: Payment
|
|
labels: [bug, backend, concurrency]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Backend: on-demand RN reconciliation in getPaymentById can race — double-processing risk
|
|
|
|
**Severity:** medium
|
|
**Domain:** Payment
|
|
**Labels:** bug, backend, concurrency
|
|
|
|
## Description
|
|
|
|
`paymentController.ts:407-466` triggers RN reconciliation on every `GET /payment/:id` call. If two browser tabs or requests call this concurrently on a pending payment, both can read `status:'pending'` and both trigger the completion side-effects before either write commits.
|
|
|
|
## Options
|
|
|
|
1. Use an atomic `findOneAndUpdate` guarded on `status:'pending'` so only one writer wins.
|
|
2. Add a distributed lock (Redis) around reconciliation per payment.
|
|
3. Move reconciliation off the read path into a single-writer background job.
|
|
|
|
## Recommendation
|
|
|
|
Make the status transition atomic (`findOneAndUpdate` filtering on current status) so only the first concurrent caller advances it; ideally move reconciliation off the GET path.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/services/payment/paymentController.ts:407-466`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-37
|