dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.3 KiB
Markdown
39 lines
1.3 KiB
Markdown
---
|
|
issue: 059
|
|
title: "Frontend auth provider clears tokens on any non-403 error including network failures"
|
|
severity: high
|
|
domain: Authentication
|
|
labels: [bug, frontend, session]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend auth provider clears tokens on any non-403 error including network failures
|
|
|
|
**Severity:** high
|
|
**Domain:** Authentication
|
|
**Labels:** bug, frontend, session
|
|
|
|
## Description
|
|
|
|
`src/auth/context/jwt/auth-provider.tsx:85` clears tokens and logs out the user on any error from the session-check call, including transient network failures and 5xx server errors. A momentary connectivity issue or backend restart silently logs out all active users.
|
|
|
|
## Options
|
|
|
|
1. Clear only on 401/403; treat 5xx and network errors as transient (keep tokens, retry).
|
|
2. Clear on 401/403 plus explicit invalid-token responses; keep tokens for everything else.
|
|
3. Add retry/backoff before deciding to clear.
|
|
|
|
## Recommendation
|
|
|
|
Clear tokens only on 401/403; on network/5xx errors keep the session and retry. Confirm acceptable retry behavior and UX with owner.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/src/auth/context/jwt/auth-provider.tsx:85`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-12
|