dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.4 KiB
1.4 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 126 | Backend: getUserPoints writes full User document on read when points fields missing | low | Points |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: getUserPoints writes full User document on read when points fields missing
Severity: low Domain: Points Labels: bug, backend, performance
Description
PointsService.ts:202 lazy-initializes points, referralCode, and referralStats fields by calling user.save() if they are missing. This means every GET /points call for a user without these fields triggers a full document write, risking concurrent update conflicts and inflating write load.
Options
- Initialize these fields at user creation (migration + signup default) so reads never write.
- Use a targeted
$setupdate instead of fullsavewhen missing. - Leave lazy init but guard against the referralCode generation loop.
Recommendation
Initialize points/referralCode/referralStats at signup (plus a one-time backfill migration) so GETs never trigger writes.
Affected Files
backend/src/services/points/PointsService.ts:202backend/src/services/auth/authService.ts— user creation path
References
- Full Codebase Audit 2026-05-30 — DEC-48