Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.2 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

009

archiveConversation uses PUT but backend only accepts PATCH

major

chat

frontend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 archiveConversation uses PUT but backend only accepts PATCH

Severity: major Domain: chat Labels: frontend, bug

Description

frontend/src/actions/chat.ts (line ~289) calls axiosInstance.put(endpoints.chat.archive, ...). The backend registers this route as PATCH /api/chat/:id/archive. Express treats PUT and PATCH as distinct methods; PUT will not match the PATCH handler and returns 404/405.

Current Behavior

Attempting to archive a conversation from the UI sends PUT /api/chat/:id/archive → 404. The chat is not archived.

Expected Behavior

archiveConversation should use axiosInstance.patch(...) to match the backend's PATCH registration. The endpoint also has toggle semantics — calling it on an archived chat unarchives it.

Affected Files

frontend/src/actions/chat.ts — archiveConversation method verb (put → patch)

References

Doc vs Code Audit Report — Finding C20

1.2 KiB Raw Blame History