Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.7 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

001

PATCH /api/disputes/:id/status has no role guard — privilege escalation

critical

dispute

security

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 PATCH /api/disputes/:id/status has no role guard — privilege escalation

Severity: critical Domain: dispute Labels: security, backend, bug

Description

PATCH /api/disputes/:id/status is mounted with only authenticateToken middleware — no authorizeRoles('admin') guard. Any authenticated buyer or seller who knows a dispute _id can change that dispute's status to resolved, closed, or any other value including states that release funds or trigger bans.

Current Behavior

Any authenticated user (buyer or seller) can call:

PATCH /api/disputes/{disputeId}/status
{ "status": "resolved" }

and receive a 200 response. The dispute status is updated in MongoDB.

Expected Behavior

Only users with role: admin should be permitted to change a dispute's status. Non-admin tokens should receive 403 Forbidden.

Reproduction Steps

Log in as a buyer or seller, obtain a JWT.
Find or create a dispute _id.
PATCH /api/disputes/{id}/status with { "status": "resolved" } and the buyer/seller Bearer token.
Observe 200 and the status change in the DB.

Affected Files

backend/src/routes/disputeRoutes.ts — router missing authorizeRoles('admin') before updateStatus handler
backend/src/controllers/disputeController.ts — updateStatus method

References

Doc vs Code Audit Report — Finding C16
Related: ISSUE-002-dispute-resolve-no-role-guard

1.7 KiB Raw Blame History