dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.4 KiB
Markdown
39 lines
1.4 KiB
Markdown
---
|
|
issue: 058
|
|
title: "Frontend test payment mode enablable in production via NEXT_PUBLIC env var"
|
|
severity: high
|
|
domain: Payment
|
|
labels: [security, frontend, test-bypass]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend test payment mode enablable in production via NEXT_PUBLIC env var
|
|
|
|
**Severity:** high
|
|
**Domain:** Payment
|
|
**Labels:** security, frontend, test-bypass
|
|
|
|
## Description
|
|
|
|
`isTestPaymentEnabled()` in `src/web3/services/test-payment-service.ts` is gated only on `NEXT_PUBLIC_ENABLE_TEST_PAYMENT` env flag. Setting this flag in a production deployment (intentionally or by misconfiguration) activates test-payment mode, which bypasses real payment flows.
|
|
|
|
## Options
|
|
|
|
1. Gate `isTestPaymentEnabled()` on `(process.env.NODE_ENV !== 'production') AND` the env flag — code-level hard stop.
|
|
2. Strip the test-payment code path entirely from production via a build-time define/dead-code elimination.
|
|
3. Both: NODE_ENV guard plus CI assertion that the flag is unset in prod env.
|
|
|
|
## Recommendation
|
|
|
|
Require `NODE_ENV !== 'production'` in addition to the flag, and add a CI check that `NEXT_PUBLIC_ENABLE_TEST_PAYMENT` is absent in production secrets.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/src/web3/services/test-payment-service.ts:131`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-3
|