Files

Siavash Sameni dceaf82934 audit: 2026-05-30 full-codebase audit — report, issues, docs, runbooks

Full-codebase-audit 2026-05-30 outputs:
- Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md
- 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer).
- Scanner docs from scratch (was zero): architecture, data model, API ref, payment
  flow, operations runbook + repo README.
- Doc-sync updates across API reference, data models, flows, design system.
- Secret Rotation Runbook (08 - Operations) for the exposed credentials.
- Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js.

Issues remain status:open intentionally — the code fixes are uncommitted-then-committed
working-tree changes per repo and aren't "resolved" until merged/deployed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-05-30 18:48:04 +04:00

1.4 KiB

Raw Blame History

issue, title, severity, domain, status, resolved, fix, labels, status, created, source

issue

title

severity

domain

status

resolved

fix

labels

status

created

source

039

reset-password-with-code endpoint has no password complexity validation — accepts weak passwords rejected by token-based reset

major

Authentication

resolved

2026-05-29

Added complexity validation in authController.resetPasswordWithCode: min 8 chars, requires uppercase, lowercase, and digit.

security

bug

backend

major

auth

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 reset-password-with-code endpoint has no password complexity validation — accepts weak passwords rejected by token-based reset

Severity: major Domain: Authentication Labels: security, bug, backend, major, auth

Description

POST /api/auth/reset-password-with-code has no validation middleware (authRoutes.ts:54-56). A new password of '123456' or 'aaaaaa' is accepted. POST /api/auth/reset-password uses passwordResetValidation enforcing uppercase+lowercase+digit. Inconsistent security between the two reset paths.

Current Behavior

Code-based password reset accepts any non-empty password without complexity requirements.

Expected Behavior

POST /api/auth/reset-password-with-code should apply the same passwordResetValidation middleware as the token-based reset.

Affected Files

backend/src/routes/authRoutes.ts

References

Doc vs Code Audit Report

1.4 KiB Raw Blame History