Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.6 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

004

fetch-tx, auto-fetch-missing, and debug payment endpoints have no authentication

critical

payment

security

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 fetch-tx, auto-fetch-missing, and debug payment endpoints have no authentication

Severity: critical Domain: payment Labels: security, backend, bug

Description

Three backend payment endpoints are mounted with no authenticateToken middleware, despite being documented as admin-only:

POST /api/payment/payments/:id/fetch-tx — triggers on-chain transaction fetch for a payment
POST /api/payment/payments/auto-fetch-missing — triggers bulk on-chain fetch for all pending payments
GET /api/payment/payments/:id/debug — returns full payment document including blockchain metadata and wallet monitor state

Any unauthenticated caller (no Authorization header needed) can call all three endpoints.

Current Behavior

curl -X POST https://api.example.com/api/payment/payments/anyId/fetch-tx
# Returns 200 and triggers on-chain state write

Expected Behavior

All three endpoints should require authenticateToken + authorizeRoles('admin') and return 401 without credentials.

Affected Files

backend/src/routes/paymentRoutes.js — route definitions for fetch-tx, auto-fetch-missing, debug

References

Doc vs Code Audit Report — Findings C28, M40
Related: ISSUE-005-scanner-status-no-auth

1.6 KiB Raw Blame History