7a616744f4
Remaining docs updated to match code (the docs that the first pass had not covered):
- Flows: Chat, Referral, Rating, Registration, Google OAuth, Negotiation, Payout,
Trezor Safekeeping — corrected endpoints, socket events, status enums, auth gaps
- API Reference: User API, Trezor API — admin route prefix/verb/status corrections,
added undocumented endpoints (ton-proof challenge, profile email verify,
GET /trezor/account, POST /trezor/verify-operation)
- Data Models: Chat, Notification, Payment, PointTransaction, User — corrected
enums (PaymentProvider, escrowState, PointTransaction.type, User.status),
90-day notification TTL, soft-delete semantics, wallet fields
Trezor "zero frontend" finding (audit C31/C32) corrected as STALE:
- Verified current code HAS a full frontend Trezor implementation (admin/trezor
page, TrezorSettingsView, trezorConnector via @trezor/connect-web,
TrezorSignDialog, actions/trezor.ts building the {message,signature} object)
- Fixed Trezor Safekeeping Flow doc (removed false "no frontend" warnings)
- Reclassified ISSUE-012 as invalid/superseded with explanation
Issue set reconciled to a single canonical numbering (ISSUE-001..054):
- Adopted the comprehensive 51-issue set (long-slug, fully indexed)
- Removed 35 superseded short-slug duplicates from the first pass
- Removed a duplicate ISSUE-046 file
- Added 3 issues the 51-set lacked: ISSUE-052 (completed-not-counted-in-stats),
ISSUE-053 (axios 401-only interceptor), ISSUE-054 (rate limiter counts all attempts)
- Regenerated Issues Index: 53 open (14 critical, 39 major) + 1 invalid
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.5 KiB
1.5 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | ||
|---|---|---|---|---|---|---|---|---|---|
| 054 | Login rate limiter counts all attempts (not just failures) — users locked out after correct logins | major | Authentication |
|
open | 2026-05-29 | Doc vs Code Audit 2026-05-29 |
🟠 Login rate limiter counts all attempts (not just failures) — users locked out after correct logins
Severity: major Domain: Authentication Labels: backend, bug
Description
rateLimitService.checkLoginAttempts() calls checkLimit() → redisService.incr, incrementing the counter on every login invocation, before password comparison. The counter only resets after a fully successful login. So 5 total attempts within 15 min (any mix of correct/incorrect passwords) triggers the lockout — not 5 failures as the docs imply.
Current Behavior
5 total login attempts within 15 minutes → 429 TOO_MANY_ATTEMPTS, even if some attempts used the correct password.
Expected Behavior
The counter should increment only on a failed password comparison, not on every attempt. Otherwise document the actual behaviour so UX warns users appropriately.
Affected Files
backend/src/services/auth/rateLimitService.ts—checkLoginAttempts/checkLimitbackend/src/controllers/authController.ts— move the increment to after password comparison
References
- Doc vs Code Audit Report — Finding M3