dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.2 KiB
Markdown
40 lines
1.2 KiB
Markdown
---
|
|
issue: 031
|
|
title: "POST /api/points/admin/add admin check is inside handler only — no middleware-level enforcement"
|
|
severity: major
|
|
domain: Admin
|
|
status: resolved
|
|
resolved: 2026-05-29
|
|
fix: "Replaced inline admin check with authorizeRoles('admin') middleware on POST /admin/add in pointsRoutes.ts."
|
|
labels: [security, bug, backend, major, missing-auth]
|
|
status: open
|
|
created: 2026-05-29
|
|
source: Doc vs Code Audit 2026-05-29
|
|
---
|
|
|
|
# 🟠 POST /api/points/admin/add admin check is inside handler only — no middleware-level enforcement
|
|
|
|
**Severity:** major
|
|
**Domain:** Admin
|
|
**Labels:** security, bug, backend, major, missing-auth
|
|
|
|
## Description
|
|
|
|
POST /api/points/admin/add registers authenticateToken only at the route level. Admin role check runs inside the handler. This means the handler code runs before the role is verified, creating potential for edge-case bypass.
|
|
|
|
## Current Behavior
|
|
|
|
The handler code begins executing for any authenticated user before the role check fires.
|
|
|
|
## Expected Behavior
|
|
|
|
Apply authorizeRoles('admin') middleware at the route level.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/routes/pointsRoutes.ts`
|
|
|
|
## References
|
|
|
|
- [Doc vs Code Audit Report](../09%20-%20Audits/Doc%20vs%20Code%20Audit%20Report%20-%202026-05-29.md)
|