dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
issue: 130
|
|
title: "Scanner: Config.GetChain/GetToken/GetRPC O(N) linear scans — pre-index at load time"
|
|
severity: low
|
|
domain: Scanner
|
|
labels: [performance, scanner]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Scanner: Config.GetChain/GetToken/GetRPC O(N) linear scans — pre-index at load time
|
|
|
|
**Severity:** low
|
|
**Domain:** Scanner
|
|
**Labels:** performance, scanner
|
|
|
|
## Description
|
|
|
|
`scanner/config.go:199` implements `GetChain`, `GetToken`, and `GetRPC` as linear scans over slices on every call. While chain count is small, these are called in hot paths (per-intent lookups). Pre-building maps at config load would eliminate all repeated scans.
|
|
|
|
## Options
|
|
|
|
1. Build maps (by chainId, token key) once at config load.
|
|
2. Leave as-is given small chain count.
|
|
3. Cache results per request.
|
|
|
|
## Recommendation
|
|
|
|
Build lookup maps at config load; trivial change but slightly alters config initialization.
|
|
|
|
## Affected Files
|
|
|
|
- `scanner/config.go:199`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-69
|