dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.1 KiB
1.1 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 124 | Backend: per-seller socket emit loop in updatePurchaseRequestStatus | low | Marketplace |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: per-seller socket emit loop in updatePurchaseRequestStatus
Severity: low Domain: Marketplace Labels: performance, backend, realtime
Description
paymentCoordinator.ts:427 emits a socket event to each seller individually in a loop. With many sellers subscribed to a purchase request, this creates N socket emits per status change. A room-based broadcast would emit once.
Options
- Emit once to a shared request room that sellers join.
- Keep per-seller but batch/await in parallel.
- Leave as-is given small N.
Recommendation
Move to a room-based broadcast when convenient; low urgency at current N.
Affected Files
backend/src/services/payment/paymentCoordinator.ts:427
References
- Full Codebase Audit 2026-05-30 — DEC-45