dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
issue: 108
|
|
title: "Scanner: unauthenticated startup when SCANNER_API_KEY unset"
|
|
severity: medium
|
|
domain: Scanner
|
|
labels: [security, scanner, configuration]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Scanner: unauthenticated startup when SCANNER_API_KEY unset
|
|
|
|
**Severity:** medium
|
|
**Domain:** Scanner
|
|
**Labels:** security, scanner, configuration
|
|
|
|
## Description
|
|
|
|
`scanner/config.go:111` logs a warning when `SCANNER_API_KEY` is empty but allows the server to start and accept unauthenticated requests. An operator mistake or CI misconfiguration can deploy a scanner that accepts any intent without an API key.
|
|
|
|
## Options
|
|
|
|
1. Fail fast in non-dev when `SCANNER_API_KEY` is empty.
|
|
2. Allow empty key only when bound to localhost; refuse otherwise.
|
|
3. Keep warning but add a required-in-prod env flag.
|
|
|
|
## Recommendation
|
|
|
|
Refuse to start (or restrict to loopback) when no API key is set outside local dev.
|
|
|
|
## Affected Files
|
|
|
|
- `scanner/config.go:111`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-60
|