dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
issue: 125
|
|
title: "Backend: getCategoryPath unbounded sequential findById loop"
|
|
severity: low
|
|
domain: Marketplace
|
|
labels: [performance, backend]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Backend: getCategoryPath unbounded sequential findById loop
|
|
|
|
**Severity:** low
|
|
**Domain:** Marketplace
|
|
**Labels:** performance, backend
|
|
|
|
## Description
|
|
|
|
`CategoryService.ts:142` builds a category breadcrumb path by looping and calling `findById` once per ancestor level. For a 5-level category tree, this is 5 sequential DB round-trips per request.
|
|
|
|
## Options
|
|
|
|
1. Load all categories once (already cached) and walk the tree in memory.
|
|
2. Maintain a denormalized `path`/`ancestors` field on each category.
|
|
3. Leave as-is for shallow trees.
|
|
|
|
## Recommendation
|
|
|
|
Build the path from the in-memory category cache; consider a denormalized `ancestors` field for deeper trees.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/services/marketplace/CategoryService.ts:142`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-47
|