dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.2 KiB
Markdown
40 lines
1.2 KiB
Markdown
---
|
|
issue: 122
|
|
title: "Backend: missing compound index for seller-visibility purchase-request query"
|
|
severity: low
|
|
domain: Marketplace
|
|
labels: [performance, backend, database]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Backend: missing compound index for seller-visibility purchase-request query
|
|
|
|
**Severity:** low
|
|
**Domain:** Marketplace
|
|
**Labels:** performance, backend, database
|
|
|
|
## Description
|
|
|
|
`PurchaseRequestService.ts:267` queries PurchaseRequests for the public marketplace feed filtering by `status` and `isPublic`. Without a compound index, this requires a collection scan on every marketplace page load.
|
|
|
|
## Options
|
|
|
|
1. Add `{ status:1, isPublic:1 }` (and possibly `createdAt:-1`) compound index.
|
|
2. Add a covering index including sort fields.
|
|
3. Profile actual query plans first, then index.
|
|
|
|
## Recommendation
|
|
|
|
Add a `{ status:1, isPublic:1, createdAt:-1 }` compound index after confirming the dominant query shape. Indexing has write-cost trade-offs.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/services/marketplace/PurchaseRequestService.ts:267`
|
|
- `backend/src/models/PurchaseRequest.ts` — index definition
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-43
|