dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.2 KiB
Markdown
40 lines
1.2 KiB
Markdown
---
|
|
issue: 109
|
|
title: "Scanner: Tron lag metric reported in ms, not blocks — inconsistent with EVM chains"
|
|
severity: medium
|
|
domain: Scanner
|
|
labels: [scanner, observability]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Scanner: Tron lag metric reported in ms, not blocks — inconsistent with EVM chains
|
|
|
|
**Severity:** medium
|
|
**Domain:** Scanner
|
|
**Labels:** scanner, observability
|
|
|
|
## Description
|
|
|
|
`scanner/api.go:55` reports Tron lag in milliseconds while EVM chains report lag in blocks. Monitoring dashboards and alerts that compare lag across chains will produce incorrect comparisons.
|
|
|
|
## Options
|
|
|
|
1. Convert Tron lag to blocks (divide by ~3s block time) to match EVM semantics.
|
|
2. Keep ms but relabel the field/units and fix the comment and alerts.
|
|
3. Report a normalized seconds value across all chains.
|
|
|
|
## Recommendation
|
|
|
|
Pick a consistent unit (blocks for EVM/Tron, or seconds everywhere), update the struct comment and any alerts. Affects monitoring contracts.
|
|
|
|
## Affected Files
|
|
|
|
- `scanner/api.go:55`
|
|
- Status struct and any Prometheus/monitoring config
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-64
|