dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.4 KiB
Markdown
39 lines
1.4 KiB
Markdown
---
|
|
issue: 096
|
|
title: "Backend: validateStatusTransition requires escrowState 'funded' never set on completed payments"
|
|
severity: medium
|
|
domain: Payment
|
|
labels: [bug, backend, state-machine]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Backend: validateStatusTransition requires escrowState 'funded' never set on completed payments
|
|
|
|
**Severity:** medium
|
|
**Domain:** Payment
|
|
**Labels:** bug, backend, state-machine
|
|
|
|
## Description
|
|
|
|
`marketplaceController.ts:570-583` guards a status transition by querying for `{ status:'completed', escrowState:'funded' }`. The completion flow never sets `escrowState:'funded'`; it is set earlier (at funding time). A genuinely completed payment may not match this query, causing the guard to reject valid transitions.
|
|
|
|
## Options
|
|
|
|
1. Query by `status:'completed'` only (drop `escrowState:'funded'`).
|
|
2. Ensure the completion flow sets `escrowState:'funded'` consistently and keep the guard.
|
|
3. Match on a documented completed-payment predicate aligned with the actual write path.
|
|
|
|
## Recommendation
|
|
|
|
Align the guard with what the completion flow actually writes — most safely query `status:'completed'` without the `escrowState` constraint, after confirming no false positives.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/services/marketplace/marketplaceController.ts:570-583`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-34
|