dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.3 KiB
Markdown
40 lines
1.3 KiB
Markdown
---
|
|
issue: 076
|
|
title: "Scanner: SSRF via unvalidated callbackUrl on intent creation"
|
|
severity: high
|
|
domain: Scanner
|
|
labels: [security, scanner, ssrf]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Scanner: SSRF via unvalidated callbackUrl on intent creation
|
|
|
|
**Severity:** high
|
|
**Domain:** Scanner
|
|
**Labels:** security, scanner, ssrf
|
|
|
|
## Description
|
|
|
|
`scanner/api.go:143` accepts a caller-supplied `callbackUrl` without validating the scheme, host, or whether it points to an internal/RFC-1918 address. A caller can set `callbackUrl` to any internal service URL and receive webhook deliveries from the scanner, enabling server-side request forgery.
|
|
|
|
## Options
|
|
|
|
1. Allowlist schemes (`https` only) and reject RFC-1918/link-local/loopback hosts at create time and at dial time via a custom `DialContext`.
|
|
2. Restrict callbacks to a configured set of backend hostnames.
|
|
3. Route webhooks through an egress proxy that blocks internal ranges.
|
|
|
|
## Recommendation
|
|
|
|
Enforce `https`-only + block private/loopback/link-local at both validation and dial time (custom `DialContext`), ideally plus a host allowlist.
|
|
|
|
## Affected Files
|
|
|
|
- `scanner/api.go:143`
|
|
- `scanner/webhook.go` — dial path
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-57
|