dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.2 KiB
Markdown
39 lines
1.2 KiB
Markdown
---
|
|
issue: 063
|
|
title: "Backend: legacy marketplace PATCH /payments/:id lets buyer/seller set any status"
|
|
severity: high
|
|
domain: Payment
|
|
labels: [security, backend, authorization]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Backend: legacy marketplace PATCH /payments/:id lets buyer/seller set any status
|
|
|
|
**Severity:** high
|
|
**Domain:** Payment
|
|
**Labels:** security, backend, authorization
|
|
|
|
## Description
|
|
|
|
`backend/src/services/marketplace/routes.ts:237` registers a legacy PATCH endpoint for payment status that has no admin guard and no status whitelist. Buyers or sellers can set any status value directly.
|
|
|
|
## Options
|
|
|
|
1. Add admin role guard + status whitelist.
|
|
2. Deprecate/remove the legacy route if superseded by the new payment controller.
|
|
3. Restrict to system/internal callers only.
|
|
|
|
## Recommendation
|
|
|
|
If the route is legacy and superseded by the new payment controller, remove it. Otherwise gate with admin + whitelist. Needs confirmation that it is unused before removal.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/services/marketplace/routes.ts:237`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-24
|