dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.4 KiB
Markdown
40 lines
1.4 KiB
Markdown
---
|
|
issue: 027
|
|
title: "confirm-delivery endpoint has no ownership check — any authenticated user can confirm delivery on any request"
|
|
severity: major
|
|
domain: Delivery
|
|
labels: [security, bug, backend, major, authorization]
|
|
status: resolved
|
|
resolved: 2026-05-29
|
|
fix: "Added buyer ownership check in marketplaceController.confirmDelivery — rejects with 403 if caller is not the request's buyerId and not admin."
|
|
status: open
|
|
created: 2026-05-29
|
|
source: Doc vs Code Audit 2026-05-29
|
|
---
|
|
|
|
# 🟠 confirm-delivery endpoint has no ownership check — any authenticated user can confirm delivery on any request
|
|
|
|
**Severity:** major
|
|
**Domain:** Delivery
|
|
**Labels:** security, bug, backend, major, authorization
|
|
|
|
## Description
|
|
|
|
marketplaceController.confirmDelivery (line 782) checks dispute gate and status === 'delivery' but does NOT verify the caller is the buyer of the request. Any authenticated user who knows a purchaseRequestId in 'delivery' status can call PATCH /confirm-delivery and advance it to 'delivered'.
|
|
|
|
## Current Behavior
|
|
|
|
Sellers, admins, or any authenticated third party can call confirm-delivery and mark a request as delivered without the buyer's involvement.
|
|
|
|
## Expected Behavior
|
|
|
|
confirmDelivery should verify req.user.id === purchaseRequest.buyerId before proceeding.
|
|
|
|
## Affected Files
|
|
|
|
- `backend/src/controllers/marketplaceController.ts`
|
|
|
|
## References
|
|
|
|
- [Doc vs Code Audit Report](../09%20-%20Audits/Doc%20vs%20Code%20Audit%20Report%20-%202026-05-29.md)
|