dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.1 KiB
Markdown
39 lines
1.1 KiB
Markdown
---
|
|
issue: 114
|
|
title: "Frontend: WalletConnect/Google client IDs hardcoded as Dockerfile ARG defaults"
|
|
severity: low
|
|
domain: Security
|
|
labels: [frontend, configuration, ci-cd]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend: WalletConnect/Google client IDs hardcoded as Dockerfile ARG defaults
|
|
|
|
**Severity:** low
|
|
**Domain:** Security
|
|
**Labels:** frontend, configuration, ci-cd
|
|
|
|
## Description
|
|
|
|
`frontend/Dockerfile:14` has hardcoded default values for `NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID` and `NEXT_PUBLIC_GOOGLE_CLIENT_ID` in `ARG` defaults. Forks or copies of this repo will silently use production IDs without being aware.
|
|
|
|
## Options
|
|
|
|
1. Remove defaults; require build-args/CI to supply them.
|
|
2. Keep defaults since values are public-by-design but document them.
|
|
3. Move to runtime env only.
|
|
|
|
## Recommendation
|
|
|
|
Remove the baked defaults and supply via CI build-args to avoid forks reusing prod IDs. These values are public but should be explicit.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/Dockerfile:14`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-74
|