Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
41 lines
1.4 KiB
Markdown
41 lines
1.4 KiB
Markdown
---
|
|
issue: 090
|
|
title: "Frontend: chat views re-fetch full conversation on every new-message socket event"
|
|
severity: medium
|
|
domain: Chat
|
|
labels: [performance, frontend]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend: chat views re-fetch full conversation on every new-message socket event
|
|
|
|
**Severity:** medium
|
|
**Domain:** Chat
|
|
**Labels:** performance, frontend
|
|
|
|
## Description
|
|
|
|
`src/sections/chat/view/buyer-chat-view.tsx:157` calls the full conversation fetch whenever a `new-message` socket event fires. With the chat messages stored as an embedded array (see ISSUE-072), this re-fetches the entire conversation history on every incoming message, causing high network and backend load in active chats.
|
|
|
|
## Options
|
|
|
|
1. Append the message from the socket payload to local state; only re-fetch on gaps/errors.
|
|
2. Keep re-fetch but debounce it.
|
|
3. Hybrid: optimistic append plus periodic reconciliation.
|
|
|
|
## Recommendation
|
|
|
|
Append the payload message directly and reconcile only on inconsistency. This changes data-flow correctness assumptions.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/src/sections/chat/view/buyer-chat-view.tsx:157`
|
|
- `frontend/src/sections/chat/view/seller-chat-view.tsx` (similar pattern)
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-20
|
|
- [[ISSUE-072-backend-chat-messages-stored-as-embedded-array-unbounded-growth|ISSUE-072]]
|