dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
39 lines
1.4 KiB
Markdown
39 lines
1.4 KiB
Markdown
---
|
|
issue: 089
|
|
title: "Frontend: admin payments-awaiting-confirmation polls every 12s unconditionally"
|
|
severity: medium
|
|
domain: Admin
|
|
labels: [performance, frontend, polling]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Frontend: admin payments-awaiting-confirmation polls every 12s unconditionally
|
|
|
|
**Severity:** medium
|
|
**Domain:** Admin
|
|
**Labels:** performance, frontend, polling
|
|
|
|
## Description
|
|
|
|
`payments-awaiting-confirmation-list-view.tsx:95` polls the backend every 12 seconds regardless of tab visibility or socket connectivity. NB-49 added visibility-gating as a no-brainer, but the longer-term question of whether to replace polling with socket subscriptions remains.
|
|
|
|
## Options
|
|
|
|
1. Pause polling when `document.visibilityState === 'hidden'` and increase interval (applied via NB-49).
|
|
2. Replace polling with a socket subscription for awaiting-confirmation events — best but needs backend events.
|
|
3. Both: visibility-gated polling now, socket later.
|
|
|
|
## Recommendation
|
|
|
|
NB-49 applied the visibility gate. Plan a socket subscription for awaiting-confirmation events to eliminate polling entirely. Confirm acceptable notification latency with owner.
|
|
|
|
## Affected Files
|
|
|
|
- `frontend/src/sections/admin/payments-awaiting-confirmation/payments-awaiting-confirmation-list-view.tsx:95`
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-18
|