dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
40 lines
1.3 KiB
Markdown
40 lines
1.3 KiB
Markdown
---
|
|
issue: 077
|
|
title: "Scanner: caller can override confirmation threshold down to 1 — reorg safety bypass"
|
|
severity: high
|
|
domain: Scanner
|
|
labels: [security, scanner, reorg]
|
|
status: open
|
|
created: 2026-05-30
|
|
source: Full Codebase Audit 2026-05-30
|
|
---
|
|
|
|
# Scanner: caller can override confirmation threshold down to 1 — reorg safety bypass
|
|
|
|
**Severity:** high
|
|
**Domain:** Scanner
|
|
**Labels:** security, scanner, reorg
|
|
|
|
## Description
|
|
|
|
`scanner/api.go:170` accepts a caller-supplied `confirmations` value and uses it as-is without enforcing the chain-config threshold as a floor. A caller can set `confirmations: 1` on a chain that requires 12 confirmations, bypassing reorg safety and causing premature payment confirmation.
|
|
|
|
## Options
|
|
|
|
1. Clamp confirmations to `max(callerValue, chainConfigThreshold)` — config is a floor.
|
|
2. Ignore caller value entirely; always use chain config.
|
|
3. Allow override only above the chain threshold.
|
|
|
|
## Recommendation
|
|
|
|
Treat the chain config threshold as a hard floor (`max` of caller and config). Changes reorg-safety semantics.
|
|
|
|
## Affected Files
|
|
|
|
- `scanner/api.go:170`
|
|
- `scanner/config.go` — chain threshold definition
|
|
|
|
## References
|
|
|
|
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-58
|