0683dde5d3
cargo-xwin drives the Windows MSVC cross-compile via clang-cl, under which CMake sets MSVC=1 — causing libopus 1.3.1's `if(NOT MSVC)` guards to skip the per-file `-msse4.1` / `-mssse3` COMPILE_FLAGS that its x86 SIMD source files need. Clang-cl (unlike real cl.exe) still honors Clang's target-feature system, so those files then fail to compile with "always_inline function '_mm_cvtepi16_epi32' requires target feature 'sse4.1'" errors across silk/NSQ_sse4_1.c, NSQ_del_dec_sse4_1.c, and VQ_WMat_EC_sse4_1.c. Earlier attempts to fix this downstream (cargo-xwin toolchain file, override.cmake CMAKE_C_COMPILE_OBJECT <FLAGS> replace, CFLAGS env vars) all failed because cargo-xwin rewrites override.cmake from scratch on every `cargo xwin build` invocation and cmake-rs's -DCMAKE_C_FLAGS= assembly happens before toolchain FORCE sets propagate. Fixing it upstream at the source: vendor audiopus_sys 0.2.2 into vendor/audiopus_sys, patch its bundled opus/CMakeLists.txt to introduce an MSVC_CL var (true only when CMAKE_C_COMPILER_ID == "MSVC", i.e. real cl.exe), and flip the eight `if(NOT MSVC)` SIMD guards to `if(NOT MSVC_CL)`. Clang-cl then gets the GCC-style per-file flags and the SSE4.1 sources build cleanly. Also flip the `if(MSVC)` global /arch block at line 445 to `if(MSVC_CL)` so only cl.exe applies /arch:AVX and clang-cl relies purely on per-file flags (no global/per-file mixing). Wire via [patch.crates-io] in the workspace root Cargo.toml; the patch is resolved relative to the workspace root as `vendor/audiopus_sys`. Upstream context: xiph/opus#256, xiph/opus PR #257 (both stale). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
44 lines
1.4 KiB
Plaintext
44 lines
1.4 KiB
Plaintext
= Release checklist =
|
|
|
|
== Source release ==
|
|
|
|
- Check for uncommitted changes to master.
|
|
- Update OPUS_LT_* API versioning in configure.ac.
|
|
- Tag the release commit with 'git tag -s vN.M'.
|
|
- Include release notes in the tag annotation.
|
|
- Verify 'make distcheck' produces a tarball with
|
|
the desired name.
|
|
- Push tag to public repo.
|
|
- Upload source package 'opus-${version}.tar.gz'
|
|
- Add to https://svn.xiph.org/releases/opus/
|
|
- Update checksum files
|
|
- svn commit
|
|
- Copy to archive.mozilla.org/pub/opus/
|
|
- Update checksum files there as well.
|
|
- Add release notes to https://gitlab.xiph.org/xiph/opus-website.git
|
|
- Update links and checksums on the downloads page.
|
|
- Add a copy of the documentation to <https://www.opus-codec.org/docs/>
|
|
and update the links.
|
|
- Update /topic in #opus IRC channel.
|
|
|
|
Releases are commited to https://svn.xiph.org/releases/opus/
|
|
which propagates to downloads.xiph.org, and copied manually
|
|
to https://archive.mozilla.org/pub/opus/
|
|
|
|
Website updates are committed to https://gitlab.xiph.org/xiph/opus-website.git
|
|
which propagates to https://opus-codec.org/
|
|
|
|
== Binary release ==
|
|
|
|
We usually build opus-tools binaries for MacOS and Windows.
|
|
|
|
Binary releases are copied manually to
|
|
https://archive.mozilla.org/pub/opus/win32/
|
|
|
|
For Mac, submit a pull request to homebrew.
|
|
|
|
== Website updates ==
|
|
|
|
For major releases, recreate the files on https://opus-codec.org/examples/
|
|
with the next encoder.
|