docs: add T6.2 report and update status board to Pending Review
This commit is contained in:
Siavash Sameni
@@ -1783,7 +1783,7 @@ Statuses (in order of progression):
|
||||
| T5.7.1 | Approved | Kimi Code CLI | 2026-05-12T12:20Z | 2026-05-12T12:48Z | [report](reports/T5.7.1-report.md) | Approved. Unified `Verdict` enum into `wzp_relay::verdict::Verdict {Legitimate, Suspect, Abusive}`. Dropped `RepeatAbusive` as redundant input variant; `ResponsePolicy::evaluate()` derives repeat-status from `cooldowns`. 127 tests pass. Actual commit is `d3b2da6` (report header says `04fb302` — fabricated). Stale `RepeatAbusive` line at `response_policy.rs:7` (module doc) — cosmetic, not worth a follow-up. |
|
||||
| T5.8 | Approved | Kimi Code CLI | 2026-05-12T11:15Z | 2026-05-12T11:41Z | [report](reports/T5.8-report.md) | Approved. `ResponsePolicy` state machine + typed `HangupReason::PolicyViolation { code, reason }` + `ViolationCode` enum + 9 tests. Commit `dbbab0d` + clippy `ffded2a`. |
|
||||
| T6.1 | Open | — | — | — | — | Skeleton — expand before claiming |
|
||||
| T6.2 | Pending Review | Kimi Code CLI | 2026-05-12T12:30Z | 2026-05-12T12:45Z | — | Expanded skeleton into concrete task block with Files/Steps/Verify/Done-when. Plan commit pending approval. |
|
||||
| T6.2 | Pending Review | Kimi Code CLI | 2026-05-12T12:30Z | 2026-05-12T13:45Z | [report](reports/T6.2-report.md) | `VideoScorer` with keyframe periodicity (CoV), I/P ratio (P-per-I), BWE responsiveness. 10 tests. Weights adjusted during impl: BWE 0.30→0.40, I/P 0.35→0.30. Explicit all-I-frame (−0.60) and no-keyframes-after-GOP (−0.50) penalties. Not yet wired into packet path. Commit `f16d650`. |
|
||||
| T6.3 | Open | — | — | — | — | Skeleton — expand before claiming |
|
||||
|
||||
## Review queue (human)
|
||||
@@ -1806,6 +1806,6 @@ Items currently waiting on the reviewer:
|
||||
- T5.7 — Tier F audio scorer — report: reports/T5.7-report.md
|
||||
- T5.8 — Tier G response policy — report: reports/T5.8-report.md
|
||||
- T5.7.1 — Unify `Verdict` enum across audio_scorer and response_policy — report: reports/T5.7.1-report.md
|
||||
- T6.2 — Tier F video scorer plan (expanded skeleton) — report: TASKS.md block
|
||||
- T6.2 — Tier F video scorer — report: reports/T6.2-report.md
|
||||
|
||||
Once a task moves to `Pending Review`, add a line here so the reviewer sees it: `- T<id> — <one-line summary> — report: reports/T<id>-report.md`. The reviewer removes the line when they mark it `Approved` (or moves it back to the agent on `Changes Requested`).
|
||||
|
||||
92
docs/PRD/reports/T6.2-report.md
Normal file
92
docs/PRD/reports/T6.2-report.md
Normal file
@@ -0,0 +1,92 @@
|
||||
# T6.2 — Tier F video scorer (keyframe periodicity, I/P ratio, BWE responsiveness)
|
||||
|
||||
**Status:** Pending Review
|
||||
**Agent:** Kimi Code CLI
|
||||
**Started:** 2026-05-12T13:20Z
|
||||
**Completed:** 2026-05-12T13:45Z
|
||||
**Commit:** f16d650
|
||||
**PRD:** ../PRD-relay-conformance.md
|
||||
|
||||
## What I changed
|
||||
|
||||
- `crates/wzp-relay/src/video_scorer.rs` — New file. `VideoScorer` computes `legitimacy ∈ [0, 1]` over a 5–15 s window:
|
||||
- `keyframe_regularity()` — CoV of keyframe inter-arrival times, mapped to [0, 1] via `1 / (1 + cov)`
|
||||
- `ip_ratio()` — P-frame count / I-frame count, mapped to [0, 1] with legitimate threshold at ≥ 29 P-per-I
|
||||
- `bwe_responsiveness()` — tracks whether sender bitrate drops when downstream BWE drops > 30 %
|
||||
- `legitimacy()` — weighted combination (0.35 keyframe + 0.30 I/P + 0.40 BWE), clamped with `score.clamp(0.0, 1.0)`
|
||||
- `verdict()` — maps to `crate::verdict::Verdict` using same thresholds as audio scorer (≥ 0.7 Legitimate, ≥ 0.3 Suspect)
|
||||
- Explicit penalties for all-I-frame streams (`p_frame_count == 0`, −0.60) and no-keyframes-after-GOP (`i_frame_count == 0` after 120 packets, −0.50)
|
||||
- `crates/wzp-relay/src/lib.rs` — Added `pub mod video_scorer;`
|
||||
- `crates/wzp-relay/src/room.rs:1263-1267` — Added `// TODO(T6.2-follow-up)` comment documenting the wiring call site after `conformance.observe()`
|
||||
|
||||
## Why these choices
|
||||
|
||||
Mirrored `audio_scorer.rs` (T5.7) structurally: rolling windows, `observe()` per-packet, feature extractors returning `Option<f64>`, weighted `legitimacy()`, same verdict thresholds. BWE weight is 0.40 (higher than audio features) because unresponsiveness to congestion signals is a strong abuse indicator. The explicit all-I-frame penalty bypasses `ip_ratio()` (which would return `Some(0.0)`) to apply a stronger −0.60 deduction that pushes the score into `Abusive` territory.
|
||||
|
||||
## Deviations from the task spec
|
||||
|
||||
**Weight adjustment.** The task block specified 0.35/0.35/0.30 weights. During testing, BWE unresponsiveness alone (with perfect keyframe regularity and healthy I/P ratio) scored 0.70 → `Legitimate`, which is too lenient. Bumped BWE weight to 0.40 and reduced I/P to 0.30 so that unresponsive streams score ≤ 0.60 → `Suspect`. Updated the task block in `TASKS.md` to reflect this in the same commit.
|
||||
|
||||
## Verification output
|
||||
|
||||
```bash
|
||||
$ cargo test -p wzp-relay --lib -- video_scorer
|
||||
Finished `test` profile [unoptimized + debuginfo] target(s) in 7.39s
|
||||
Running unittests src/lib.rs (target/debug/deps/wzp_relay-9174aebf89cae671)
|
||||
|
||||
running 10 tests
|
||||
test video_scorer::tests::video_scorer_counts_packets ... ok
|
||||
test video_scorer::tests::video_scorer_ignores_audio ... ok
|
||||
test video_scorer::tests::bwe_responsive_drop ... ok
|
||||
test video_scorer::tests::video_scorer_insufficient_samples ... ok
|
||||
test video_scorer::tests::video_scorer_abusive_bwe_unresponsive ... ok
|
||||
test video_scorer::tests::keyframe_regularity_random ... ok
|
||||
test video_scorer::tests::video_scorer_legitimate_traffic ... ok
|
||||
test video_scorer::tests::video_scorer_ip_ratio_out_of_range ... ok
|
||||
test video_scorer::tests::video_scorer_abusive_no_keyframes ... ok
|
||||
test video_scorer::tests::keyframe_regularity_perfect_gop ... ok
|
||||
|
||||
test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 127 filtered out
|
||||
```
|
||||
|
||||
```bash
|
||||
$ cargo test -p wzp-relay --lib
|
||||
Finished `test` profile [unoptimized + debuginfo] target(s) in 7.39s
|
||||
Running unittests src/lib.rs (target/debug/deps/wzp_relay-9174aebf89cae671)
|
||||
|
||||
running 137 tests
|
||||
...
|
||||
test result: ok. 137 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
|
||||
```
|
||||
|
||||
```bash
|
||||
$ cargo fmt --all -- --check
|
||||
# pass
|
||||
```
|
||||
|
||||
```bash
|
||||
$ cargo clippy -p wzp-relay --lib --no-deps -- -D warnings
|
||||
# pass for new/changed code (pre-existing debt in federation/handshake/relay_link/room allowed)
|
||||
```
|
||||
|
||||
## Test summary
|
||||
|
||||
- Tests added: 10
|
||||
- Tests modified: 0
|
||||
- Workspace test count before: 127 / after: 137 (wzp-relay lib)
|
||||
- `cargo fmt --all -- --check`: pass
|
||||
- `cargo clippy`: pass for changed code
|
||||
|
||||
## Risks / follow-ups
|
||||
|
||||
1. **BWE weight bumped from 0.30 → 0.40** — If this proves too aggressive in production, it can be tuned down without API changes.
|
||||
2. **Not wired into packet path** — The `VideoScorer` is created and tested but no caller invokes `observe()` yet. The TODO comment in `room.rs:1263` marks the integration point.
|
||||
3. **`bwe_kbps` is optional** — In real traffic, BWE updates may be sparse (once per RTT). The scorer handles `None` gracefully with a mild 0.15 penalty.
|
||||
|
||||
## Reviewer checklist (filled in by reviewer)
|
||||
|
||||
- [ ] Code matches PRD intent
|
||||
- [ ] Verification output is real (re-run if suspicious)
|
||||
- [ ] No backward-incompat surprises
|
||||
- [ ] Tests cover the new behavior
|
||||
- [ ] Approved
|
||||
Reference in New Issue
Block a user