dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.0 KiB
1.0 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 095 | Backend: getUserStats has no ownership/admin check (IDOR) | medium | Payment |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: getUserStats has no ownership/admin check (IDOR)
Severity: medium Domain: Payment Labels: security, backend, idor
Description
paymentControllerRoutes.ts:13 serves GET /api/payment/stats/:userId without checking that req.user.id === req.params.userId or that the caller is an admin. Any authenticated user can retrieve payment statistics for any other user ID.
Options
- Require
req.user.id === req.params.userId, or admin. - Admin-only endpoint.
- Scope query to the authenticated user, ignore param.
Recommendation
Require self-or-admin (req.user.id === userId || isAdmin).
Affected Files
backend/src/services/payment/paymentControllerRoutes.ts:13
References
- Full Codebase Audit 2026-05-30 — DEC-29