Files
nick-doc/Issues/ISSUE-025-get-api-disputes-statistics-has-no-admin-role-guard-any-auth.md
Siavash Sameni dceaf82934 audit: 2026-05-30 full-codebase audit — report, issues, docs, runbooks
Full-codebase-audit 2026-05-30 outputs:
- Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md
- 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer).
- Scanner docs from scratch (was zero): architecture, data model, API ref, payment
  flow, operations runbook + repo README.
- Doc-sync updates across API reference, data models, flows, design system.
- Secret Rotation Runbook (08 - Operations) for the exposed credentials.
- Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js.

Issues remain status:open intentionally — the code fixes are uncommitted-then-committed
working-tree changes per repo and aren't "resolved" until merged/deployed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-05-30 18:48:04 +04:00

1.3 KiB

issue, title, severity, domain, status, resolved, fix, labels, status, created, source
issue title severity domain status resolved fix labels status created source
025 GET /api/disputes/statistics has no admin role guard — any authenticated user can access aggregate dispute KPIs major Dispute resolved 2026-05-29 Added authorizeRoles('admin', 'resolver') to GET /statistics in disputeRoutes.ts.
security
bug
backend
major
privilege-escalation
open 2026-05-29 Doc vs Code Audit 2026-05-29

🟠 GET /api/disputes/statistics has no admin role guard — any authenticated user can access aggregate dispute KPIs

Severity: major Domain: Dispute Labels: security, bug, backend, major, privilege-escalation

Description

Backend registers GET /api/disputes/statistics with authenticateToken only. No authorizeRoles(admin) guard is applied at the route or controller level. Any authenticated non-admin user can access aggregate dispute platform data.

Current Behavior

Non-admin authenticated users can call GET /api/disputes/statistics and receive platform-wide KPI data.

Expected Behavior

Return 403 for non-admin tokens. Apply authorizeRoles('admin') at the route level.

Affected Files

  • backend/src/routes/disputeRoutes.ts

References