dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.4 KiB
1.4 KiB
issue, title, severity, domain, status, resolved, fix, labels, status, created, source
| issue | title | severity | domain | status | resolved | fix | labels | status | created | source | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 030 | POST /api/payment/payments/cleanup-pending admin check is inside handler only — no middleware-level enforcement | major | Admin | resolved | 2026-05-29 | Moved admin check to middleware: added authorizeRoles('admin') to cleanup-pending route in paymentRoutes.ts and removed inline role check. |
|
open | 2026-05-29 | Doc vs Code Audit 2026-05-29 |
🟠 POST /api/payment/payments/cleanup-pending admin check is inside handler only — no middleware-level enforcement
Severity: major Domain: Admin Labels: security, bug, backend, major, missing-auth
Description
POST /api/payment/payments/cleanup-pending registers only authenticateToken at the route level. Admin check is inside the handler. Any authenticated non-admin who discovers this endpoint can attempt to call it; the in-handler check is the only defense against unauthorized bulk deletion of pending payments.
Current Behavior
Non-admin authenticated users can call the endpoint; admin gate fires inside handler code rather than at middleware level.
Expected Behavior
Apply authorizeRoles('admin') middleware at the route level before the handler runs.
Affected Files
backend/src/routes/paymentRoutes.ts