dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.7 KiB
issue, title, severity, domain, status, resolved, fix, labels, status, created, source
| issue | title | severity | domain | status | resolved | fix | labels | status | created | source | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 013 | createProviderPaymentIntent always routes to request-network/intents regardless of provider argument | critical | Payment | resolved | 2026-05-29 | Replaced stub getProviderIntentEndpoint in payment.ts with a switch on provider: shkeeper → shkeeper.intents, decentralized → decentralized.save, default → requestNetwork.intents. |
|
open | 2026-05-29 | Doc vs Code Audit 2026-05-29 |
🔴 createProviderPaymentIntent always routes to request-network/intents regardless of provider argument
Severity: critical Domain: Payment Labels: bug, frontend, critical, payment, routing
Description
src/actions/payment.ts getProviderIntentEndpoint() ignores the provider parameter and always returns endpoints.payments.requestNetwork.intents ('/payment/request-network/intents'). Any checkout using provider='shkeeper' silently POSTs to the wrong backend service.
Current Behavior
SHKeeper checkout silently POSTs to /payment/request-network/intents instead of /payment/shkeeper/intents, causing payment intent creation to fail or create a wrong-provider payment record.
Expected Behavior
getProviderIntentEndpoint() should return the correct provider-specific endpoint based on the provider argument (e.g., endpoints.payments.shkeeper.intents for 'shkeeper').
Reproduction Steps
Initiate a SHKeeper checkout and intercept network — observe the POST goes to /payment/request-network/intents not /payment/shkeeper/intents.
Affected Files
frontend/src/actions/payment.ts