nick/nick-doc
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
Files
bee91dd01fd217c51a3c71e79a3d8aeb01a68c05
nick-doc/Issues/ISSUE-087-frontend-getpaymentstatus-and-checkpaymentstatus-hit-different.md
Siavash Sameni dceaf82934 audit: 2026-05-30 full-codebase audit — report, issues, docs, runbooks 
Full-codebase-audit 2026-05-30 outputs:
- Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md
- 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer).
- Scanner docs from scratch (was zero): architecture, data model, API ref, payment
  flow, operations runbook + repo README.
- Doc-sync updates across API reference, data models, flows, design system.
- Secret Rotation Runbook (08 - Operations) for the exposed credentials.
- Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js.

Issues remain status:open intentionally — the code fixes are uncommitted-then-committed
working-tree changes per repo and aren't "resolved" until merged/deployed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-05-30 18:48:04 +04:00

1.3 KiB
Raw Blame History

issue, title, severity, domain, labels, status, created, source
issue title severity domain labels status created source
087 Frontend: getPaymentStatus and checkPaymentStatus hit different endpoints medium Payment
bug
frontend
open 2026-05-30 Full Codebase Audit 2026-05-30

Frontend: getPaymentStatus and checkPaymentStatus hit different endpoints

Severity: medium Domain: Payment Labels: bug, frontend

Description

src/actions/payment.ts:62 has two functions — getPaymentStatus and checkPaymentStatus — that appear to serve the same purpose but call different endpoints (/payment/:id/status vs /payment/payments/:id/status). Only one of these can be the correct backend path.

Options

  1. Point getPaymentStatus at the registry-defined /payment/:id/status and deduplicate with checkPaymentStatus.
  2. Add /payment/payments/:id/status to the endpoints registry if backend truly serves it.
  3. Remove the redundant getPaymentStatus and migrate callers to checkPaymentStatus.

Recommendation

Verify the real backend route, then collapse to a single function using the registry path. Could break callers, so verify before removing.

Affected Files

  • frontend/src/actions/payment.ts:62

References

Reference in New Issue View Git Blame Copy Permalink