Files
nick-doc/Issues/ISSUE-012-trezor-safekeeping-zero-frontend-implementation-all-admin-re.md
Siavash Sameni 7a616744f4 docs: complete code-reality alignment for remaining docs + reconcile issue set
Remaining docs updated to match code (the docs that the first pass had not covered):
- Flows: Chat, Referral, Rating, Registration, Google OAuth, Negotiation, Payout,
  Trezor Safekeeping — corrected endpoints, socket events, status enums, auth gaps
- API Reference: User API, Trezor API — admin route prefix/verb/status corrections,
  added undocumented endpoints (ton-proof challenge, profile email verify,
  GET /trezor/account, POST /trezor/verify-operation)
- Data Models: Chat, Notification, Payment, PointTransaction, User — corrected
  enums (PaymentProvider, escrowState, PointTransaction.type, User.status),
  90-day notification TTL, soft-delete semantics, wallet fields

Trezor "zero frontend" finding (audit C31/C32) corrected as STALE:
- Verified current code HAS a full frontend Trezor implementation (admin/trezor
  page, TrezorSettingsView, trezorConnector via @trezor/connect-web,
  TrezorSignDialog, actions/trezor.ts building the {message,signature} object)
- Fixed Trezor Safekeeping Flow doc (removed false "no frontend" warnings)
- Reclassified ISSUE-012 as invalid/superseded with explanation

Issue set reconciled to a single canonical numbering (ISSUE-001..054):
- Adopted the comprehensive 51-issue set (long-slug, fully indexed)
- Removed 35 superseded short-slug duplicates from the first pass
- Removed a duplicate ISSUE-046 file
- Added 3 issues the 51-set lacked: ISSUE-052 (completed-not-counted-in-stats),
  ISSUE-053 (axios 401-only interceptor), ISSUE-054 (rate limiter counts all attempts)
- Regenerated Issues Index: 53 open (14 critical, 39 major) + 1 invalid

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-05-29 15:15:02 +04:00

2.3 KiB

issue, title, severity, domain, labels, status, created, resolved, source
issue title severity domain labels status created resolved source
012 Trezor Safekeeping frontend — audit 'zero frontend' finding was STALE (feature exists) info Trezor
invalid
stale-audit
trezor
frontend
invalid 2026-05-29 2026-05-29 Doc vs Code Audit 2026-05-29

INVALID — Trezor Safekeeping frontend DOES exist (audit finding was stale)

Severity: info (was: critical) Domain: Trezor Status: INVALID — the audit's "zero frontend implementation" claim (findings C31/C32) was generated from an older code snapshot. The frontend Trezor implementation exists in current code.

Why this is not a bug

A direct re-check of the current frontend on 2026-05-29 confirmed a complete Trezor implementation:

  • frontend/src/app/dashboard/admin/trezor/page.tsx → renders TrezorSettingsView (registration + re-register UI)
  • frontend/src/sections/admin/trezor/trezor-settings-view.tsx → settings/registration view (~14KB)
  • frontend/src/web3/trezor/trezorConnector.ts → lazy-imports @trezor/connect-web; implements trezorGetXpub, trezorGetAddress, trezorSignMessage
  • frontend/src/components/trezor-sign-dialog/TrezorSignDialog.tsx → full stepper: build instruction → sign on Trezor → enter txHash → confirm
  • frontend/src/actions/trezor.ts → complete API client: getTrezorAccount, getTrezorRegistrationMessage, registerTrezor, getTrezorOperationMessage, confirmRelease, confirmRefund — and it builds the trezor: { message, signature } object in the confirmation body

The active admin release/refund path goes through TrezorSignDialogactions/trezor.ts, which does satisfy the backend assertTrezorSignatureForOperation guard when TREZOR_SAFEKEEPING_REQUIRED=true.

Residual note (not a blocker)

The legacy helpers confirmReleaseTx / confirmRefundTx in frontend/src/actions/payment.ts post only { txHash } with no trezor field — but they have no UI callers and are dead code. Consider removing them to avoid confusion. Tracked as a minor cleanup, not a release blocker.

References