dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.3 KiB
1.3 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 076 | Scanner: SSRF via unvalidated callbackUrl on intent creation | high | Scanner |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Scanner: SSRF via unvalidated callbackUrl on intent creation
Severity: high Domain: Scanner Labels: security, scanner, ssrf
Description
scanner/api.go:143 accepts a caller-supplied callbackUrl without validating the scheme, host, or whether it points to an internal/RFC-1918 address. A caller can set callbackUrl to any internal service URL and receive webhook deliveries from the scanner, enabling server-side request forgery.
Options
- Allowlist schemes (
httpsonly) and reject RFC-1918/link-local/loopback hosts at create time and at dial time via a customDialContext. - Restrict callbacks to a configured set of backend hostnames.
- Route webhooks through an egress proxy that blocks internal ranges.
Recommendation
Enforce https-only + block private/loopback/link-local at both validation and dial time (custom DialContext), ideally plus a host allowlist.
Affected Files
scanner/api.go:143scanner/webhook.go— dial path
References
- Full Codebase Audit 2026-05-30 — DEC-57