dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.3 KiB
1.3 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 088 | Frontend: adminWalletPayout falls back to literal 'admin' adminUserId | medium | Payment |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Frontend: adminWalletPayout falls back to literal 'admin' adminUserId
Severity: medium Domain: Payment Labels: bug, frontend, authorization
Description
src/actions/payment.ts:663 sends adminUserId: adminUserId || 'admin'. When the admin user ID is not available (e.g. context not loaded), the string literal 'admin' is sent to the backend. This may match a user record named 'admin' unintentionally or corrupt audit trails.
Options
- Require
adminUserIdand throw/abort if absent (no fallback). - Source
adminUserIdfrom the authenticated admin context automatically. - Keep a fallback but use the real admin id from token rather than the string
'admin'.
Recommendation
Remove the 'admin' literal and require a real admin id from the auth context; abort if unavailable. This affects audit/authorization semantics.
Affected Files
frontend/src/actions/payment.ts:663
References
- Full Codebase Audit 2026-05-30 — DEC-17