dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.2 KiB
1.2 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 063 | Backend: legacy marketplace PATCH /payments/:id lets buyer/seller set any status | high | Payment |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: legacy marketplace PATCH /payments/:id lets buyer/seller set any status
Severity: high Domain: Payment Labels: security, backend, authorization
Description
backend/src/services/marketplace/routes.ts:237 registers a legacy PATCH endpoint for payment status that has no admin guard and no status whitelist. Buyers or sellers can set any status value directly.
Options
- Add admin role guard + status whitelist.
- Deprecate/remove the legacy route if superseded by the new payment controller.
- Restrict to system/internal callers only.
Recommendation
If the route is legacy and superseded by the new payment controller, remove it. Otherwise gate with admin + whitelist. Needs confirmation that it is unused before removal.
Affected Files
backend/src/services/marketplace/routes.ts:237
References
- Full Codebase Audit 2026-05-30 — DEC-24