Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.3 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

030

PATCH /confirm-delivery has no ownership check — any authenticated user can confirm delivery

major

delivery

backend

security

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 PATCH /confirm-delivery has no ownership check — any authenticated user can confirm delivery

Severity: major Domain: delivery Labels: backend, security, bug

Description

PATCH /api/marketplace/purchase-requests/:id/confirm-delivery (the buyer fast-track path to 'delivered' status) has no ownership or role check. Any authenticated user who knows a purchase request ID can mark it as delivered without possessing the delivery code.

Current Behavior

PATCH /purchase-requests/{anyId}/confirm-delivery with any valid JWT → 200, status set to 'delivered'.

Expected Behavior

Should verify req.user.id === request.buyerId — only the buyer of that specific request should be able to confirm delivery via this fast-track path.

Affected Files

backend/src/routes/controllerRoutes.ts or routes.ts — confirm-delivery handler missing ownership guard

References

Doc vs Code Audit Report

1.3 KiB Raw Blame History