Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.5 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

027

GET /api/notifications/:id always 404s for non-latest notifications — broken in-memory lookup

major

notification

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 GET /api/notifications/:id always 404s for non-latest notifications — broken in-memory lookup

Severity: major Domain: notification Labels: backend, bug

Description

The getNotificationById controller does NOT perform a direct MongoDB findById lookup. Instead it calls getUserNotifications(userId, 1, 1) — fetching only the user's single most-recent notification — and then does an in-memory _id string comparison.

Any notification that is not the user's absolute latest record returns 404, regardless of ownership. This makes the endpoint completely unreliable for any consumer that tries to fetch a specific notification by ID.

Current Behavior

GET /api/notifications/abc123 returns the notification only if abc123 happens to be the user's most recently created notification. For all others: 404.

Expected Behavior

getNotificationById should do a direct Notification.findOne({ _id: id, userId }) query.

Affected Files

backend/src/services/notification/notificationService.ts (or controller) — getNotificationById / getUserNotifications call

References

Doc vs Code Audit Report — Finding C22

1.5 KiB Raw Blame History