Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.5 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

034

SellerOffer 'active' status does not exist in schema — saves with this value throw ValidationError

major

seller-offer

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 SellerOffer 'active' status does not exist in schema — saves with this value throw ValidationError

Severity: major Domain: seller-offer Labels: backend, bug

Description

The Seller Offer Flow doc lists 'active' as a valid SellerOffer.status. The Mongoose schema and TypeScript interface only enumerate:

'pending' | 'accepted' | 'rejected' | 'withdrawn'

Any code path that attempts to set SellerOffer.status = 'active' will throw a Mongoose ValidationError. The createOffer() service correctly checks PurchaseRequest.status === 'active' (a different model's status), but SellerOffer.status = 'active' is never valid.

Current Behavior

SellerOffer.save() with status: 'active' → Mongoose ValidationError. (Currently no code path actually tries to do this — the bug is latent but would be triggered by misreading the documentation.)

Expected Behavior

Remove 'active' from all SellerOffer status documentation. The valid states are pending | accepted | rejected | withdrawn.

Affected Files

Doc file updated: 04 - Flows/Seller Offer Flow.md and 02 - Data Models/SellerOffer.md

References

Doc vs Code Audit Report — Finding M22

1.5 KiB Raw Blame History