Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.7 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

016

createProviderPaymentIntent always routes to request-network regardless of provider — SHKeeper checkout broken

critical

payment

frontend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 createProviderPaymentIntent always routes to request-network regardless of provider — SHKeeper checkout broken

Severity: critical Domain: payment Labels: frontend, bug

Description

frontend/src/actions/payment.ts — getProviderIntentEndpoint() ignores its provider argument and always returns endpoints.payments.requestNetwork.intents (/payment/request-network/intents).

If any UI component passes provider='shkeeper' to createProviderPaymentIntent(), the intent creation silently POSTs to the Request Network endpoint instead of /payment/shkeeper/intents. The SHKeeper intents endpoint is defined in axios.ts but is never reached by this factory.

Current Behavior

A SHKeeper checkout call to createProviderPaymentIntent('shkeeper', ...) POSTs to /payment/request-network/intents. The RN endpoint creates a Request Network intent, not a SHKeeper intent. The payment provider is silently misrouted.

Expected Behavior

getProviderIntentEndpoint('shkeeper') should return endpoints.payments.shkeeper.intents. The function should switch on the provider argument.

Affected Files

frontend/src/actions/payment.ts — getProviderIntentEndpoint() function (~line 444)

References

Doc vs Code Audit Report — Finding M38
Related: ISSUE-017-payment-provider-type-missing-values

1.7 KiB Raw Blame History