Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.6 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

014

select-offer sends no per-seller socket events or notifications to winning/losing sellers

major

seller-offer

backend

missing-feature

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 select-offer sends no per-seller socket events or notifications to winning/losing sellers

Severity: major Domain: seller-offer Labels: backend, missing-feature

Description

POST /api/marketplace/purchase-requests/:id/select-offer (routes.ts lines ~1300-1438) emits only a single purchase-request-update event to the request room with eventType: 'offer-selected'. It does NOT:

Call notifyOfferAccepted for the winning seller
Call notifyOfferRejected for losing sellers
Emit seller-offer-update events to individual seller rooms

These notifications only fire when using PUT /offers/:id/accept or PUT /offers/:id/status (via SellerOfferService.updateOfferStatus), not via the select-offer path used by the frontend.

Current Behavior

Buyer selects an offer → winning seller gets no real-time notification → losing sellers get no notification.

Expected Behavior

When a buyer selects an offer:

Winning seller receives a seller-offer-update event and a push notification
Losing sellers receive a seller-offer-update event and a notification

Affected Files

backend/src/routes/routes.ts — select-offer route handler, missing notifyOfferAccepted and notifyOfferRejected calls

References

Doc vs Code Audit Report — Finding M25

1.6 KiB Raw Blame History