Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.9 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

010

Admin user status/role actions broken: wrong HTTP verb (PUT vs PATCH) and wrong status values

critical

admin

frontend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 Admin user status/role actions broken: wrong HTTP verb (PUT vs PATCH) and wrong status values

Severity: critical Domain: admin Labels: frontend, bug

Description

Two separate bugs on the admin user management actions:

Bug 1 — Wrong HTTP verb: frontend/src/actions/user.ts:

updateUserStatus calls axiosInstance.put(...) — backend registers PATCH
updateUserRole calls axiosInstance.put(...) — backend registers PATCH

Both will 404/405 in production since Express doesn't alias PUT to PATCH.

Bug 2 — Wrong status values: updateUserStatus accepts and sends 'active' | 'inactive' | 'pending'. The backend User.status enum only accepts 'active' | 'suspended' | 'deleted'. Sending 'inactive' or 'pending' is silently rejected or ignored. 'suspended' is completely absent from the frontend type.

Current Behavior

Clicking "Suspend user" in admin panel sends PUT /api/users/admin/:userId/status with { status: 'inactive' } → 404 and wrong value
Clicking "Update role" sends PUT /api/users/admin/:userId/role → 404

Expected Behavior

Use axiosInstance.patch(...) for both actions
Status values should be 'active' | 'suspended' | 'deleted' to match the backend enum

Affected Files

frontend/src/actions/user.ts — updateUserStatus (line ~162), updateUserRole (line ~175)
frontend/src/types/user.ts (line ~159) — status union type needs to include 'suspended' and remove 'inactive'/'pending'

References

Doc vs Code Audit Report — Findings C26, C27

1.9 KiB Raw Blame History