Files

Siavash Sameni a1f056e6a5 docs: align flow docs with code reality + create 35 implementation issue files

Flow docs updated (11 files):
- Delivery Confirmation: reversed actor roles (buyer generates, seller verifies),
  fixed endpoint paths (/delivery-code/generate, /delivery-code/verify)
- Passkey (WebAuthn): removed stub/simulated-key claims; real @simplewebauthn/server
  attestation is implemented; refresh tokens are persisted
- Dispute: corrected resolve schema (action enum), removed non-existent statuses,
  documented security gaps (no role guards on status/resolve/assign), route shadowing,
  all socket events are TODO stubs
- Seller Offer: corrected all endpoint paths, removed 'active' status, documented
  withdraw dead code, missing seller history page, select-offer notification gap
- Notification: corrected mark-all-read method+path, fixed GET /:id broken lookup,
  added unread-count-update socket event
- Authentication: corrected rate limiter (counts all attempts), axios 403 not handled,
  deleteAccount wrong endpoint bug, changePassword no UI
- Password Reset: corrected 6-digit code (not 8), documented no-complexity gap on
  reset-with-code vs token reset
- Payment Flow DePay: /create→/save, removed phantom sub-routes, SIM_ bypass risk,
  PaymentProvider type gap, getProviderIntentEndpoint routing bug
- Payment Flow SHKeeper: removed phantom polling endpoint, fixed release/refund paths
- Purchase Request: added pending_payment/active statuses, fixed sellers/attachments
  endpoints, corrected socket events, PUT→PATCH bug
- Escrow: documented dispute resolve does not touch escrow, route shadowing, confirm-delivery auth gap

Issues created (35 files in Issues/):
- 9 security issues (critical) including: dispute privilege escalation ×4,
  unauthenticated payment/scanner endpoints ×2, SIM_ production bypass,
  confirm-delivery ownership gap
- 26 additional major/critical bugs covering broken endpoints, missing features,
  data integrity gaps, and frontend-backend mismatches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-29 14:47:49 +04:00

1.8 KiB

Raw Blame History

issue, title, severity, domain, labels, status, created, source

issue

title

severity

domain

labels

status

created

source

003

Route shadowing: two dispute routers mounted at /api/disputes cause non-deterministic handler dispatch

critical

dispute

backend

bug

open

2026-05-29

Doc vs Code Audit 2026-05-29

🔴 Route shadowing: two dispute routers mounted at /api/disputes cause non-deterministic handler dispatch

Severity: critical Domain: dispute Labels: backend, bug

Description

In backend/src/app.ts, two separate dispute routers are mounted on the same path /api/disputes:

Line ~521: dashboardDisputeRoutes (first — unguarded POST /:id/resolve, PATCH /:id/status)
Line ~585: releaseHold disputeRoutes (second — admin-guarded POST /:purchaseRequestId/resolve, also GET /:purchaseRequestId/status)

Express evaluates in registration order. A POST /api/disputes/{purchaseRequestId}/resolve request will match the dashboard router's POST /:id/resolve handler first (since :id and :purchaseRequestId are identical route patterns). This executes the unguarded Dispute CRUD resolve instead of the admin-guarded escrow release-hold logic.

Current Behavior

POST /api/disputes/{purchaseRequestId}/resolve executes the dashboard resolveDispute controller (updates the Dispute document only, no role guard) rather than the intended releaseHold handler (admin-only, clears escrow).

Expected Behavior

The escrow-release resolve handler should be reachable at a distinct, unambiguous path (e.g., /api/disputes/hold/:purchaseRequestId/resolve or mounted at a different prefix).

Affected Files

backend/src/app.ts — two app.use('/api/disputes', ...) mount points

References

Doc vs Code Audit Report — Finding C18
Related: ISSUE-002-dispute-resolve-no-role-guard

1.8 KiB Raw Blame History