Files

Siavash Sameni dceaf82934 audit: 2026-05-30 full-codebase audit — report, issues, docs, runbooks

Full-codebase-audit 2026-05-30 outputs:
- Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md
- 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer).
- Scanner docs from scratch (was zero): architecture, data model, API ref, payment
  flow, operations runbook + repo README.
- Doc-sync updates across API reference, data models, flows, design system.
- Secret Rotation Runbook (08 - Operations) for the exposed credentials.
- Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js.

Issues remain status:open intentionally — the code fixes are uncommitted-then-committed
working-tree changes per repo and aren't "resolved" until merged/deployed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-05-30 18:48:04 +04:00

1.4 KiB

Raw Blame History

issue, title, severity, domain, labels, status, resolved, fix, status, created, source

issue

title

severity

domain

labels

status

resolved

fix

status

created

source

023

GET /api/payment/export has no admin role guard at route level — any authenticated user can export all payment data

major

Payment

security

bug

backend

major

privilege-escalation

resolved

2026-05-29

Already guarded by authenticateToken + authorizeRoles('admin') at paymentRoutes.ts line 79. Confirmed in current code.

open

2026-05-29

Doc vs Code Audit 2026-05-29

🟠 GET /api/payment/export has no admin role guard at route level — any authenticated user can export all payment data

Severity: major Domain: Payment Labels: security, bug, backend, major, privilege-escalation

Description

GET /api/payment/export (controller-pattern route) has only authenticateToken — no admin guard at the router level. The parallel /api/payment/payments/export route has an admin role guard. The frontend hits the non-admin-gated path. Any authenticated buyer can export all payment records.

Current Behavior

Non-admin buyers can call GET /api/payment/export and receive payment export data for all users.

Expected Behavior

GET /api/payment/export should apply authorizeRoles('admin') at the route level.

Affected Files

backend/src/routes/paymentRoutes.ts

References

Doc vs Code Audit Report

1.4 KiB Raw Blame History