dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.3 KiB
1.3 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 091 | Frontend: dual socket connections (SocketProvider + socketService singleton) | medium | Realtime |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Frontend: dual socket connections (SocketProvider + socketService singleton)
Severity: medium Domain: Realtime Labels: bug, frontend, performance
Description
src/socket/lib/socket-service.ts:217 creates a standalone socket.io connection separate from the SocketProvider context. Both may connect simultaneously, resulting in duplicate connections to the backend, doubled event delivery, and doubled auth overhead.
Options
- Make
socketServicedelegate to theSocketProviderconnection (single source of truth). - Migrate all
actions/chat.tsusages to the context provider and deletesocketService. - Keep both but ensure only one actually connects.
Recommendation
Consolidate onto SocketProvider and refactor socketService callers; remove the duplicate connection. This is a large refactor.
Affected Files
frontend/src/socket/lib/socket-service.ts:217frontend/src/actions/chat.ts— socketService callers
References
- Full Codebase Audit 2026-05-30 — DEC-21